Conversation
Why these changes are being introduced: The ECR Repository infrastruture is in place in dev, stage, and prod AWS accounts, so we have the outputs for the Makefile and the three GHA workflows in TfCloud. Once deployed, these workflows will build/ deploy the container using our usual GitHub-flow model (new PR will push a container to dev, merged PR will push a container to stage, and a tagged release on main will push a container to prod). How this addresses that need: * Add Terraform-generated dev build and dev deploy targets to the Makefile * Create the dev, stage, and prod build/deploy GHA workflows using the text generated by the mitlib-tf-workloads-ecr repository None. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-169
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ghukill
approved these changes
Nov 10, 2025
Collaborator
ghukill
left a comment
ghukill
left a comment
There was a problem hiding this comment.
Looks great! Was able to confirm local builds, push to ECR, and even a test ECS task run via a shimmed task definition I had (spike-proj-use-embed-cli-dev) that I repurporsed to point to this new image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Like all of our container-based applications that will run in AWS, we need
Makefiletargets for the developer to build and deploy the container to ECR from their workstation. And, we need GitHub Actions workflows for dev, stage, and prod builds and deploys.The workflows and the
Makefiletargets are all generated by the mitlib-tf-workloads-ecr repository (see PR#73 and PR#74).How can a reviewer manually see the effects of these changes?
The developer can checkout this branch and then run the new
makecommands (make dist-dev,make publish-dev, andmake docker-clean). After themake publish-dev, the developer can check the ECR Repository in Dev1 to see that their build was successfully pushed to the repository.The developer can also review the Actions tab and see that the
dev-buildworkflow ran properly when this PR was opened (the two Dev Container Build and Deploy jobs are listed at the bottom of this PR conversation as checks). The developer can also attempt to manually run thedev-buildworkflow in the Actions tab (since we enableworkflow_dispatchas one of the workflow triggers). This is leveraging the new "multi-arch" option to allow eitherarm64oramd64builds based on the.aws-architecturefile.At this time, there is no way to run these containers easily in AWS since the mitlib-tf-workloads-timdex-infrastructure repository has not been updated with a new task definition to pull from this repository (that will happen as part of USE-170).
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review