[STAGE=>MAIN] dsc makefile output updates for arm64 support #76
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: This commit updates the TFC Makefile outputs for the DSC app to support the ARM64 architecture. Terraform was also updated to the most recent version and the pre-commit pipeline apps were updated to the latest version. How this addresses that need: * Update the TfCloud outputs for the dsc Makefile and caller workflows * Upgrade Terraform to v1.14 * Upgrade pre-commit pipeline apps Side effects of this change: None. Relevant ticket(s): https://mitlibraries.atlassian.net/browse/IN-1631 Changes to be committed: modified: .pre-commit-config.yaml modified: .terraform.lock.hcl modified: README.md modified: dsc_ecr.tf modified: versions.tf
dsc makefile output updates for arm64 support
vab
changed the title
Contributor
Author
|
This is ready for review. But, it likely will not be immediately applied after approval. I am coordinating with Jonavelle on a testing cycle for workflow updates to the DSC container app. When she gives the go ahead, I will merge and deploy. But, I am asking for code review now in the interest of efficiency (as this code will not change despite the testing outcomes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Checklist
What does this PR do?
This PRupdates the TFC Makefile outputs for the DSC app to support the ARM64 architecture.
Terraform was also updated to the most recent version and the pre-commit pipeline apps were updated to the latest version.
How this addresses that need:
Helpful background context
The apply run for dev reverted a debugging related console ops change. The Stage plan shows no changes other than changes to the output. The production plan should also show no changes.
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/IN-1631
Requires Database Migrations?
NO
Includes new or updated dependencies?
YES - Terraform has been updated to v1.14