Merged
Conversation
Why these changes are being introduced: I missed three typos, one in a comment and two in the special Tf outputs for stage & prod. How this addresses that need: * Fix this mistaken capital letter in a comment in the providers.tf file * Fix the stage-only output to pull from the correct "extra-region" template file instead of the regular template file for the "west" region workflow lines * Fix the prod-only output to pull from the correct "extra-region" template file intead of the regular template file for the "west" region workflow lines Side effects of this change: None. Only changes outputs. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IR-238
tim-rix
approved these changes
May 9, 2025
Contributor
tim-rix
left a comment
tim-rix
left a comment
There was a problem hiding this comment.
Everything looks OK to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer Checklist
What does this PR do?
Helpful background context
I missed three typos, one in a comment and two in the special Tf outputs for stage & prod.
What are the relevant tickets?
Requires Database Migrations?
NO
Includes new or updated dependencies?
NO