Conversation
…ission and dissemination data
…, and date compare
… comparisons ignore submission and dissemination, and added a few file count and AIP comparison stats
…to a video mimetype
…order between single stats and two date comparison
ehanson8
approved these changes
May 20, 2026
Contributor
ehanson8
left a comment
ehanson8
left a comment
There was a problem hiding this comment.
Despite 2 minor typos, approved!
Comment on lines
+1186
to
+1187
| - ***Metadata:*** If a file has specific file names or is stored in specific directories that indicate it is descriptive or preservation metadata, it's status is categorized metadata. | ||
| - ***Normalized/access derivative:*** If a file has an Archivematica file UUID appended to the filename, is a PDF in a digitized AIP, is in a thumbnails directory, or is stored in the Dissemination bucket, it's status is categorized normalized/access derivative. |
Contributor
There was a problem hiding this comment.
Minor: should be its rather than it's for these 2
Collaborator
Author
There was a problem hiding this comment.
added another commit, can you please review?
Coverage Report for CI Build 26171224962Coverage decreased (-0.3%) to 13.983%Details
Uncovered Changes
Coverage Regressions6 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ehanson8
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
This PR adds functionality that supports submission and dissemination bucket data analysis, a few new data points, and reorganizes the comparison code to mimic the structure of the single day summary.
How can a reviewer manually see the effects of these changes?
Run Marimo and see how the app works
Includes new or updated dependencies?
YES - updated version of urllib
Changes expectations for external applications?
NO
What are the relevant tickets?
No relevant tickets, Charlie did this PR as a stakeholder.