Handle colorspace conflicts with OpenJPEG #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
force-pushed
the
handle-colorspace-conflicts
branch
2 times, most recently
from
f987cc1 to
c4d7a42
Compare
acdha
force-pushed
the
handle-colorspace-conflicts
branch
2 times, most recently
from
a8c6aea to
3db4cf6
Compare
This installs the patch from uclouvain/openjpeg#1207 to handle the case where an image has a color profile which is not compatible with the actual channel definitions.
This does not allow use of the FFMPEG processor but we didn’t need that and it reduces the container size considerably, not to mention avoiding some CVEs which are in ffmpeg dependencies and currently unfixed such as CVE-2019-14889.
acdha
force-pushed
the
handle-colorspace-conflicts
branch
2 times, most recently
from
71688b1 to
d0d67ed
Compare
acdha
force-pushed
the
handle-colorspace-conflicts
branch
from
d0d67ed to
0010b65
Compare
This appears to be a regression upstream: https://bugs.launchpad.net/ubuntu/+source/ca-certificates-java/+bug/1784553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how much OpenJPEG handling of JP2s with conflicting color definitions matters to you but if it does, this builds on #27 to add the patch from uclouvain/openjpeg#1207.