Skip to content

Conversation

@briangow
Copy link
Contributor

@briangow briangow commented Jan 8, 2026

As raised in #554, wfdb.io.Multirecord.wrsamp does not provide the option to pass expanded=True. This should be provided so that multifrequency signals can be written within the Multirecord class. This PR updates the wrsamp call to allow for expanded to be passed.

@bemoody
Copy link
Collaborator

bemoody commented Jan 9, 2026

This makes sense. But I think we should probably also have more validity checking when writing out multisegment records.

_check_segment_cohesion looks like somebody started to do that, but that function isn't used?!

@briangow
Copy link
Contributor Author

briangow commented Jan 9, 2026

Thanks @bemoody! I agree with your comment about additional validation. I've opened issue #557 to capture that. We can use separate PRs to implement those validations.

@briangow briangow merged commit 860cdb2 into main Jan 9, 2026
19 checks passed
@briangow briangow deleted the bg_multirecord_expanded branch January 9, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants