Skip to content

[true-async] + drop H3 listener #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EdmondDantes wants to merge 1 commit into from
Closed

[true-async] + drop H3 listener #743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions frameworks/true-async-server/entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
$port = (int)(getenv('PORT') ?: 8080);
$tlsPort = (int)(getenv('TLS_PORT') ?: 8443);
$h2cPort = (int)(getenv('H2C_PORT') ?: 8082);
$h3Port = (int)(getenv('H3_PORT') ?: $tlsPort);
$h3Enabled = getenv('H3_DISABLE') !== '1';
$workers = (int)(getenv('WORKERS') ?: 0);
if ($workers <= 0) {
$workers = available_parallelism();
Expand Down Expand Up @@ -85,12 +83,10 @@
->setCertificate($certPath)
->setPrivateKey($keyPath);

// HTTP/3 over QUIC on the same UDP port — powers baseline-h3 / static-h3.
// Reuses the TLS cert/key. Requires --enable-http3; if missing, the worker
// start() will throw — set H3_DISABLE=1 to skip on builds without it.
if ($h3Enabled) {
$config->addHttp3Listener('0.0.0.0', $h3Port);
}
// No HTTP/3 listener: meta.json subscribes to no h3 profile, so the
// QUIC UDP listener would be pure liability — an extra bind that races
// with the previous container's teardown on back-to-back profile runs
// and makes the server fail to come up ("did not come up" on limited-conn).
}

// Bootloader needs the class files visible in the parent too, otherwise
Expand Down