Skip to content

Implement the -s flag for //paste and fix out of bounds pastes from placing blocks in weird locations#224

Merged
StackDoubleFlow merged 6 commits intoMCHPR:masterfrom
BramOtte:paste-s
Mar 6, 2026
Merged

Implement the -s flag for //paste and fix out of bounds pastes from placing blocks in weird locations#224
StackDoubleFlow merged 6 commits intoMCHPR:masterfrom
BramOtte:paste-s

Conversation

@BramOtte
Copy link
Copy Markdown
Contributor

No description provided.

@StackDoubleFlow
Copy link
Copy Markdown
Member

I'm not sure how to feel about the bounds checking for //paste. It's pretty common (at least for me) to copy a larger area with air in it. Not only that, but sometimes you'd want to paste something just to figure out its orientation (especially schematics). I think clipping by default is actually better.

@BramOtte BramOtte changed the title Implement the -s flag for //paste and add bounds checking for //paste Implement the -s flag for //paste and fix out of bounds pastes from placing blocks in weird locations Mar 5, 2026
@BramOtte
Copy link
Copy Markdown
Contributor Author

BramOtte commented Mar 5, 2026

I'm not sure how to feel about the bounds checking for //paste. It's pretty common (at least for me) to copy a larger area with air in it. Not only that, but sometimes you'd want to paste something just to figure out its orientation (especially schematics). I think clipping by default is actually better.

ah yes I think I added bounds check because pasting out of bounds was causing issues, I now instead just fix the get_chunk_index_for_block method which should resolve those issues.

Do you think it'd be helpful to give the user a warning when pasting out of bounds or is fine to just silently clip?

@StackDoubleFlow
Copy link
Copy Markdown
Member

Just silently clipping is fine. I would rather not send something to pollute the chat box. I think it would be cool to have a warning display in the action bar, but since we don't currently have a mechnism for it, I won't hold you to it.

@StackDoubleFlow StackDoubleFlow merged commit df0f3d1 into MCHPR:master Mar 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants