Open
Conversation
… for gossip_acceptor works with country_code
…machine and in actions
…or start block request
…ot_twice to run in Actions
…in, test_node_1 does not contain local descriptor in log after startup
…dMetadata::new(), test for two debut in the same time with empty db
…se of no full naighborship in DB
…try_accept_debut, start of binary search in country_finder
…one test on testing data for ipV6 still failing
…ace tests to match countries
…andle_agrs Reply, remove target_country_opt
bertllll
reviewed
Feb 27, 2025
bertllll
reviewed
Feb 27, 2025
| .help(SHOW_COUNTRIES_HELP) | ||
| .takes_value(false) | ||
| .required(false), | ||
| ) |
Contributor
There was a problem hiding this comment.
Tady pak bys mohl pridat dalsi nastaveni pomoci 'ArgGroups', ktery ti dovoli upravovat vztah mezi jednotlivymi argumenty. Napr. kdyz je jeden pritomny, jiny nesmi byt pritomny. Muzes se inspirovat, u nejakeho jineho prikazu to take je.
Contributor
There was a problem hiding this comment.
K tomu testovani, jak ses me ptal:
Tohle lze testovat pres chybovy hlasky. V tom testu muzes dodat dva konfliktni argumenty a assertovat na chybovou hlasku (Clap si toho vsimne a zmini ten konflikt v te hlasce).
Ale bude se opet jednat pouze o unit test. Dost podobny nejakym tem, ktere uz jsi napsal.
bertllll
reviewed
Feb 27, 2025
bertllll
reviewed
Mar 3, 2025
bertllll
reviewed
Mar 3, 2025
bertllll
reviewed
Mar 4, 2025
bertllll
reviewed
Mar 4, 2025
bertllll
reviewed
Mar 5, 2025
bertllll
reviewed
Mar 5, 2025
bertllll
reviewed
Mar 5, 2025
bertllll
reviewed
Mar 6, 2025
bertllll
reviewed
Mar 6, 2025
bertllll
reviewed
Mar 6, 2025
bertllll
reviewed
Mar 7, 2025
bertllll
reviewed
Mar 7, 2025
bertllll
reviewed
Mar 7, 2025
bertllll
reviewed
Mar 8, 2025
bertllll
reviewed
Mar 9, 2025
bertllll
reviewed
Mar 9, 2025
bertllll
reviewed
Mar 12, 2025
bertllll
reviewed
Mar 14, 2025
bertllll
reviewed
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.