Skip to content

Simplify running uv sync locally#808

Open
ddabble wants to merge 1 commit into
mainfrom
dev-dependency-group-default
Open

Simplify running uv sync locally#808
ddabble wants to merge 1 commit into
mainfrom
dev-dependency-group-default

Conversation

@ddabble
Copy link
Copy Markdown
Member

@ddabble ddabble commented Mar 25, 2026

Proposed changes

Made the dev depencency group default for uv, which means that running uv sync is now in practice an alias for uv sync --group dev; the CI jobs and the Docker image should remain unchanged by this.

The original decision to not have any default groups, was for optimizing toward making it easy to specify which group should be installed for prod (i.e. only the main dependencies, so none of the dependency groups). However, since we very often install and update dependencies locally, we think it's better to facilitate that, by having fewer characters to write.

Review guidance

Deployment notes

The services and deployment scripts must be updated with the --no-default-groups flag before deploying.

Checklist

(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)

  • I've run makemigrations, makemessages and compilemessages
  • I've written tests that fail without these changes (if relevant/possible)
  • I've manually tested the website UI with different device layouts
    • Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools
  • I've manually tested with different users locally
    • This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers
  • I've made sure that my code conforms to the code style guides
    • It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request
  • I've attempted to minimize the number of common code smells
    • See the comment for the previous checkbox
  • I've added documentation
    • E.g. comments, docstrings, or in the README
  • I've added my changes to the "Unreleased" section of the changelog, together with a link to this PR
    • Mainly the changes that are of particular interest to users and/or developers, if any
  • I've added a "Deployment notes" section above and labelled the PR with has-deployment-notes
    • ...if anything out of the ordinary should be done when deploying these changes to the server (e.g. adding/removing an environment variable, manually creating/changing some objects, running a management command, etc.)
  • I've structured my commits reasonably

The original decision to not have any default groups, was for optimizing
toward making it easy to specify which group should be installed for
prod (i.e. only the main `dependencies`, so none of the dependency
groups).
However, since we very often install and update dependencies locally, we
think it's better to facilitate that, by having fewer characters to
write.

In summary, running `uv sync` is now in practice an alias for
`uv sync --group dev`; the CI jobs and the Docker image should remain
unchanged by this.
@ddabble ddabble requested a review from TheStrgamer March 25, 2026 09:47
@ddabble ddabble added the ⚡Quick review⚡ This PR is short and can be reviewed quickly. label Mar 25, 2026
@make-bot make-bot Bot moved this to Ready for Review in web Mar 25, 2026
@make-bot make-bot Bot added this to web Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.00%. Comparing base (4d8d244) to head (dab4e3e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         153      153           
  Lines        6246     6246           
=======================================
  Hits         5497     5497           
  Misses        749      749           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚡Quick review⚡ This PR is short and can be reviewed quickly.

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

1 participant