Add notebook showing COPC access in R using lasR#576
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,1395 @@ | |||
| { | |||
There was a problem hiding this comment.
Make sure it's clear this only works on the MAAP Hub, and the R pyrocket-geospatial workspace.
Reply via ReviewNB
| @@ -0,0 +1,1395 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #14. dyn.load("/srv/conda/envs/notebook/lib/libgdal.so.36"),
Hmm, what image are you working in? on pyrocket-geospatial this should not be using conda.
Reply via ReviewNB
There was a problem hiding this comment.
I removed this part to avoid confusion. It was forcing the libgdal from conda to resolve package dependency issues. Thanks
| @@ -0,0 +1,1395 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #8. # Fetch first page of items (limit=10 to get a representative sample)
We should use rstac to do STAC queries in R!
Reply via ReviewNB
| @@ -0,0 +1,1395 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
They are in local coordinate reference system.
| @@ -0,0 +1,1395 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #6. full <- exec(reader_las() + summarise(), on = url)
is exec a lasR function?
Reply via ReviewNB
There was a problem hiding this comment.
Yes. It's the pdal's pipeline.execute equivalent for lasR. Updated the code to specifically show lasR::exec()
|
@wildintellect @hrodmn Thanks for the comments. I updated the notebook and requested re-review. |
|
@omshinde how did you get lasR upgraded install to work? when I tried to build it takes a long time, and then links to the conda gdal which causes issues. |
|
I tested it again in a fresh R image and it works wit the following commands-
Verify
Verify: |
|
It's building against the conda versions of packages, which we don't want. |
|
This is what I see- |
|
MoM from lasR discussion with Sam G.
Actions:
|
|
@omshinde let's move the install/container image with lasR to it's own ticket in a workspace related repo. |
|
@HarshiniGirish @hrodmn @wildintellect Are there any more comments on this doc (not worrying about the installation)? Thanks |
| @@ -0,0 +1,1324 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #3. install.packages("rstac", repos = "https://cloud.r-project.org")
already had a dependency cell earlier. do we need it?
Reply via ReviewNB
| @@ -0,0 +1,1324 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #3. url <- "/vsis3/nasa-maap-data-store/file-staging/nasa-map/GEDI_CalVal_Lidar_COPC/usa_tepeecreek_2809704010602.copc.laz"
do we need to hardcode this as it is connected to the STAC discovery step
Reply via ReviewNB
|
looks good to me. just came across 2 minor suggestions, feel free to ignore them @omshinde |
|
I think we should close this PR. Even with the fixes it's not actually usable by users without us providing a permalink to boot the correct custom image. We're also not clearly showing the times - so we're sort of half solving the 2 things we need.
We can then rework in stages, what's ready for release and what's not. This might have been premature when all we wanted was to prove COPC access works as expected with the latest library. |
Addresses NASA-IMPACT/science-support#25