Use trait for re-usable code.

[ildyria]

Summary by CodeRabbit

• Refactor
  • Internal verification and authorization system restructured to enhance code organization and reusability throughout the codebase. All existing functionality remains unchanged with complete backward compatibility maintained.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refactors the Verify class by extracting common verification logic into a reusable VerifyTrait. The Verify class now uses this trait instead of directly implementing methods like check, is_supporter, is_pro, is_signature, authorize, and when. Configuration mapping is updated with new validation hashes.

Changes

Cohort / File(s)	Summary
Configuration Update config/verify.php	Updated Verify::class hash from 'ffd01909f5189bc7bae21266e356f83c898ccd37' to 'aba420193a9d017e36a215ef8dbd6332bd2c2525'; added VerifyTrait::class mapping; added VerifyTrait import statement
Class Refactoring src/Verify.php	Added VerifyTrait usage via use VerifyTrait;; removed six public methods (check, is_supporter, is_pro, is_signature, authorize, when) and SupporterOnlyOperationException import; retained get_status() and validate() logic
New Trait Definition src/VerifyTrait.php	Introduced new VerifyTrait with abstract get_status() method and six concrete public methods (check, is_supporter, is_pro, is_signature, authorize, when) for edition status verification and authorization enforcement

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The refactoring follows a clear pattern of method extraction into a trait with cohesive verification logic. Review effort is moderate due to multiple files with related but distinct responsibilities and the need to verify trait integration, import statements, and configuration updates.

Poem

🐰 A trait extracted with care,
Methods bundled beyond compare,
From Verify's old design,
Reusable logic so fine—
Shared behaviors everywhere! ✨

Pre-merge checks

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 87.50% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe0fa68 and 78bf450.

📒 Files selected for processing (3)

• config/verify.php
• src/Verify.php
• src/VerifyTrait.php

🧰 Additional context used

🧬 Code graph analysis (2)

src/VerifyTrait.php (2)

src/Exceptions/SupporterOnlyOperationException.php (1)

• SupporterOnlyOperationException (7-21)

src/Verify.php (1)

• get_status (42-59)

config/verify.php (1)

src/Verify.php (1)

• Verify (14-90)

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: P8.3 - L11.* - prefer-stable - windows-latest
• GitHub Check: P8.4 - L12.* - prefer-lowest - windows-latest
• GitHub Check: P8.3 - L11.* - prefer-lowest - windows-latest
• GitHub Check: P8.3 - L12.* - prefer-lowest - windows-latest

🔇 Additional comments (7)

src/VerifyTrait.php (4)

10-33: LGTM! Clean trait abstraction with correct status hierarchy logic.

The abstract method contract and the status checking logic correctly implement the edition hierarchy (SIGNATURE > PRO > SUPPORTER > FREE). The early return for FREE_EDITION and the match expression properly enforce access control.

---

40-63: LGTM! Clean delegation pattern.

The helper methods provide a convenient API by delegating to the core check() method with appropriate status levels. The PHPDoc is clear and consistent.

---

75-80: LGTM! Proper authorization guard.

The method correctly enforces access control by throwing an exception when the status check fails. The exception type is properly documented.

---

93-98: LGTM! Useful conditional utility with lazy evaluation support.

The method provides a clean branching pattern that supports both direct values and closures for deferred execution. The generic template annotation ensures type safety.

src/Verify.php (2)

66-89: LGTM! File integrity validation logic is sound.

The validate() method correctly verifies file integrity by computing SHA-1 hashes and comparing them against the configuration values. The line-ending normalization ensures consistent hashing across platforms.

---

16-16: LGTM! Proper trait adoption.

The trait is correctly integrated. The Verify class implements the required abstract get_status() method and the validate() method, satisfying all interface requirements while leveraging the five concrete helper methods provided by VerifyTrait.

config/verify.php (1)

10-10: SHA-1 hashes in config/verify.php are correct.

Verification confirms that both hash values match the actual file contents: Verify::class hash (line 17) and VerifyTrait::class hash (line 21) are accurate.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}