Skip to content

Fix not loading settings first page anymore #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ildyria merged 4 commits into from
May 22, 2026
+3 −2
Merged

Fix not loading settings first page anymore #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7099bd
Fix not loading settings first page anymore
ildyria May 21, 2026
ccaa7da
let's not display that
ildyria May 21, 2026
8b667e4
fixes
ildyria May 21, 2026
ca1cf36
fix formatting
ildyria May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
libnghttp2-14 \
libsystemd0 \
libudev1 \
libgnutls30t64 \
&& sed -i '/<\/policymap>/i \ <policy domain="coder" rights="read|write" pattern="PDF" \/>' /etc/ImageMagick-7/policy.xml \
&& install-php-extensions \
pdo_mysql \
Expand Down Expand Up @@ -124,7 +125,7 @@
COPY --from=node --chown=www-data:www-data /app/public/embed ./public/embed

# Ensure storage and bootstrap/cache are writable with minimal permissions
RUN mkdir -p storage/framework/cache \

Check failure on line 128 in Dockerfile

View workflow job for this annotation

GitHub Actions / 3️⃣ Dockerfile Lint 

SC2086 info: Double quote to prevent globbing and word splitting.
storage/framework/sessions \
storage/framework/views \
storage/logs \
Expand Down
4 changes: 2 additions & 2 deletions resources/js/views/admin/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const props = defineProps<{
}>();

const toast = useToast();
const tab = ref(props.tab);
const tab = ref(props.tab ?? ""); // Default to empty string if props.tab is undefined
const router = useRouter();
const route = useRoute();
const isReady = ref(false);
Expand Down Expand Up @@ -222,7 +222,7 @@ onMounted(() => {
watch(
() => route.params.tab,
(newTab, _oldTab) => {
tab.value = newTab as string | undefined;
tab.value = (newTab as string | undefined) ?? "";
},
);
</script>
Expand Down
Loading