-
Notifications
You must be signed in to change notification settings - Fork 3
Update repo for Vercel MKdocs compatibility #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update repo for Vercel MKdocs compatibility #23
Conversation
Co-authored-by: daanluttik <daanluttik@techonomy.nl>
Co-authored-by: daanluttik <daanluttik@techonomy.nl>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's GuideConfigure repository for Vercel MkDocs compatibility by adding deployment documentation, defining build scripts and Python dependencies, and supplying Vercel-specific build configuration to ensure proper installation and site generation. Class diagram for new configuration and build scriptsclassDiagram
class requirements.txt {
+mkdocs>=1.2.3
+mkdocs-material>=7.2.6
+PyYAML>=5.4.1
}
class package.json {
+build(): mkdocs build
+dev(): mkdocs serve
+deploy(): mkdocs gh-deploy
}
class vercel.json {
+installCommand: pip install -r requirements.txt
+buildCommand: mkdocs build
+outputDirectory: site/
}
class runtime.txt {
+python-<version>
}
requirements.txt <.. vercel.json : used by
package.json <.. vercel.json : referenced by
runtime.txt <.. vercel.json : used by
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Luttik - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `DEPLOYMENT.md:3` </location>
<code_context>
+# Deployment Guide
+
+This repository is configured to support multiple deployment options for the MKdocs documentation site.
+
+## Vercel Deployment (Recommended)
</code_context>
<issue_to_address>
Correct 'MKdocs' to 'MkDocs' for proper capitalization.
Update all occurrences of 'MKdocs' to 'MkDocs' in this document.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
This repository is configured to support multiple deployment options for the MKdocs documentation site.
=======
This repository is configured to support multiple deployment options for the MkDocs documentation site.
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `DEPLOYMENT.md:16` </location>
<code_context>
+4. Static files will be served from the `site/` directory
+
+### Configuration Files
+- `requirements.txt`: Python dependencies needed for MKdocs
+- `package.json`: Build scripts for Vercel
+- `vercel.json`: Vercel-specific configuration with Python build commands
</code_context>
<issue_to_address>
Correct 'MKdocs' to 'MkDocs' for proper capitalization.
Suggested implementation:
```
- `requirements.txt`: Python dependencies needed for MkDocs
```
```
- `mkdocs.yml`: MkDocs configuration
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -0,0 +1,56 @@ | |||
| # Deployment Guide | |||
|
|
|||
| This repository is configured to support multiple deployment options for the MKdocs documentation site. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Correct 'MKdocs' to 'MkDocs' for proper capitalization.
Update all occurrences of 'MKdocs' to 'MkDocs' in this document.
| This repository is configured to support multiple deployment options for the MKdocs documentation site. | |
| This repository is configured to support multiple deployment options for the MkDocs documentation site. |
| 4. Static files will be served from the `site/` directory | ||
|
|
||
| ### Configuration Files | ||
| - `requirements.txt`: Python dependencies needed for MKdocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Correct 'MKdocs' to 'MkDocs' for proper capitalization.
Suggested implementation:
- `requirements.txt`: Python dependencies needed for MkDocs
- `mkdocs.yml`: MkDocs configuration
Summary by Sourcery
Configure the repository to support automatic Vercel builds of the MkDocs site by adding necessary configuration files and documentation while preserving the GitHub Pages workflow.
New Features:
Enhancements:
Build:
Documentation: