ci(testing): reduce e2e test parallelism in CI to fix flaky tests#3789
ci(testing): reduce e2e test parallelism in CI to fix flaky tests#3789adrianschmidt merged 3 commits intomainfrom
Conversation
…enabled Adds a test runner wrapper script that automatically enables verbose output when debug logging is enabled. The wrapper detects ACTIONS_STEP_DEBUG, RUNNER_DEBUG, or DEBUG env vars and adds the --verbose flag to the stencil test command.
📝 WalkthroughWalkthroughAdds CI detection to test tooling: the test runner reduces worker parallelism and logs CI/debug state; Stencil test browser args now optionally include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3789/ |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@scripts/run-tests.cjs`:
- Around line 20-25: Update the comment above the CI parallelism adjustment to
accurately reflect the library version or intent: change the mention of "Stencil
v4" to "Stencil v3.4.2" (or note that this is a forward-looking workaround for
potential Stencil v4 issues) so the comment matches the project context; the
change should be made in the block that checks isCI and pushes '--max-workers=2'
(see the isCI condition, args.push('--max-workers=2') and the console.log
statement) to avoid version confusion.
In `@stencil.config.ts`:
- Around line 52-57: The browserArgs spread uses a simple truthy check on
process.env.CI which is inconsistent with run-tests.cjs; change the conditional
to use the shared helper envIsSet('CI') (the same function used in
run-tests.cjs) so edge cases like '0'/'false' are handled consistently, and add
the corresponding import for envIsSet at the top of stencil.config.ts; update
the spread expression in browserArgs to use envIsSet('CI') instead of
process.env.CI.
Work around Stencil v4 e2e test parallelization issues that cause random timeouts in CI but not locally. Changes only apply when CI=true. - Add --disable-gpu browser arg in stencil.config.ts - Add --max-workers=2 in run-tests.cjs See: stenciljs/core#6157
adrianschmidt
force-pushed
the
fix-flaky-tests
branch
from
98ef990 to
e0117c3
Compare
adrianschmidt
force-pushed
the
fix-flaky-tests
branch
from
5f17bdc to
e0117c3
Compare
adrianschmidt
force-pushed
the
add-verbose-test-logging
branch
from
a77f57d to
1e23ec8
Compare
|
🎉 This PR is included in version 38.47.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Work around Stencil v4 e2e test parallelization issues that cause random timeouts in CI but not locally. Changes only apply when CI=true.
See: stenciljs/core#6157
Summary by CodeRabbit
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: