Skip to content

Finalizing Main and starting Character page#19

Open
Balintskac wants to merge 8 commits intomasterfrom
issue1#2#3
Open

Finalizing Main and starting Character page#19
Balintskac wants to merge 8 commits intomasterfrom
issue1#2#3

Conversation

@Balintskac
Copy link
Copy Markdown
Collaborator

No description provided.

@Moondancer83 Moondancer83 added this to the Alpha milestone Sep 15, 2016
@Moondancer83
Copy link
Copy Markdown
Member

Missing "characters.js"

Copy link
Copy Markdown
Member

@Moondancer83 Moondancer83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always run your code!
Use the browser's development tools to monitor the errors. If you use Chrome, (I hope you use it.) Press Ctrl + Shift + I to open it. Open Console tab.

Comment thread src/characters.html Outdated
<title>List of characters</title>
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css">
<link rel="stylesheet" href="Stil.css">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include jquery before bootstrap.js!
Remove one of them, you included 2 different version of it!

Comment thread src/index.html
<link rel="stylesheet" href="Stil.css">


<script src="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jquery must be declared before Bootstrap js!

Comment thread src/index.html Outdated

<script src="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js"></script>
<script src="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min.js"></script>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove older version of Bootstrap!

Comment thread src/index.html
<div class="collapse navbar-collapse" id="myNavbar">
<ul class="nav navbar-nav">
<li><a href="#">Home</a></li>
<li><a href="#"> <button>Characters</button></a></li>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap uses anchors here, not buttons!
In addition your button is not working!
Define Characters instead!

Comment thread src/index.html Outdated
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css">
<link rel="stylesheet" href="Stil.css">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the Stil.css to some english word, like basic as this file is the basic sytlesheet.

Comment thread src/index.html
<title>ORCs Project</title>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same version of bootstrap for all files (css, js).

Comment thread src/index.html
<h1>Online Role-playing Characters</h1>



Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the original content of the file. Use your new content only.

@Moondancer83 Moondancer83 changed the title Issue1#2#3 Finalizing Main and starting Character page Sep 15, 2016
@Balintskac Balintskac changed the title Finalizing Main and starting Character page it's not match Sep 19, 2016
@Balintskac Balintskac changed the title it's not match Finalizing Main and starting Character page Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants