Validator UI Update #366
Merged
Validator UI Update #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LumerinIO
previously approved these changes
Feb 11, 2025
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| return false; | ||
| } | ||
| for (const elem of elems) { | ||
| const num = parseInt(elem); |
There was a problem hiding this comment.
The use of parseInt without specifying a radix can lead to unexpected results if the input contains leading zeros, as these might be interpreted as octal numbers. To ensure consistent behavior, always specify a radix of 10 when using parseInt for IP address segments.
Recommended Change:
const num = parseInt(elem, 10);| } | ||
|
|
||
| // Check if host is a valid domain name | ||
| const domainRegex = /^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])$/; |
There was a problem hiding this comment.
The regular expression used for domain name validation does not support internationalized domain names (IDNs) which can include Unicode characters. This limitation might prevent valid IDNs from being accepted.
Recommended Change:
Consider using a library or a more comprehensive regular expression that supports IDNs to enhance the domain name validation process.
older version of macos is required to build executable for intel based cpu.
lsheva
approved these changes
Feb 11, 2025
LumerinIO
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.