temp #247
Closed
temp #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review complete. Found 1 issue to address:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| if creds == nil { | ||
| return fmt.Errorf("p2p creds is nil") | ||
| } | ||
| creds.SetRemoteIdentity(target.identity) |
There was a problem hiding this comment.
The p2pCreds object is created once in newProbeClients() and reused for all probes. Calling SetRemoteIdentity() here mutates shared state. While the current probing loop is sequential, this is a latent race condition that would manifest if the code is ever refactored to probe concurrently. Consider cloning the credentials per-probe (similar to how NewSecureClientConn in conn_pool.go clones credentials) to avoid this risk.
Fix it with Roo Code or mention @roomote and request a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.