Skip to content

Conversation

@mateeullahmalik
Copy link
Contributor

No description provided.

@roomote
Copy link

roomote bot commented Dec 19, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The PR correctly updates simulation tests to handle the SuperNode/Validator 1:1 invariant by:

  • Adding GetSuperNodeByAccount to the SupernodeKeeper interface for looking up supernodes by account
  • Adding validation in SimulateMsgUpdateSupernode to ensure new accounts are not already associated with another validator
  • Adding validation in registerSupernode helper to check account availability before registration
  • Adding a new negative test SimulateMsgUpdateSupernodeInvalidAccount that verifies the system properly rejects attempts to use a conflicting supernode account
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote[bot]
roomote bot previously approved these changes Dec 19, 2025
@a-ok123 a-ok123 self-requested a review December 19, 2025 15:58
@a-ok123 a-ok123 merged commit 875aa5f into master Dec 19, 2025
8 checks passed
@mateeullahmalik mateeullahmalik deleted the fix/simulation-tests branch December 20, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants