fix(compiler): Refactor let-chains for stable rustc compatibility#175
Open
TarunvirBains wants to merge 1 commit intoLukeMathWalker:mainfrom
Open
Conversation
The previous implementation used the unstable 'let_chains' feature, which caused compilation to fail on stable Rust toolchains. This commit refactors the code to use nested 'if let' statements instead, which is compatible with stable Rust and achieves the same logic. This change fixes the build on the stable Rust release channel.
|
Hello, could you please merge this pull request? I'd like to use the stable version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used the unstable 'let_chains' && syntax, which caused compilation to fail on current Rust toolchains, in particular Rust 1.85.
This commit refactors the code to use nested 'if let' statements instead, which is compatible with stable Rust and achieves the same logic.
This change fixes the build on the stable Rust release channel.
Here is the compile message from the current main branch when I attempt to compile it:
This PR fixes the issue with the correct stable syntax`