feat: Add --ignore-manifest cook arg#309
Open
sharnoff wants to merge 1 commit intoLukeMathWalker:mainfrom
Open
feat: Add --ignore-manifest cook arg#309sharnoff wants to merge 1 commit intoLukeMathWalker:mainfrom
sharnoff wants to merge 1 commit intoLukeMathWalker:mainfrom
Conversation
One way to speed up builds involving large monomorphized dependencies is to separate their usage into a separate crate, which is then cached. It's helpful if that can be a package in the same workspace, but AFAICT cargo-chef doesn't currently have a mechanism to extend its caching to some workspace members. So to support that, let's add an `--ignore-manifest` flag to request that cargo-chef doesn't overwrite that `Cargo.toml` file or clean up the build artifacts from that package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One way to speed up builds involving large monomorphized dependencies is to separate their usage into a separate crate, which is then cached.
It's helpful if that can be a package in the same workspace, but AFAICT cargo-chef doesn't currently have a mechanism to extend its caching to some workspace members.
So to support that, this PR adds an
--ignore-manifestflag to request that cargo-chef doesn't overwrite thatCargo.tomlfile or clean up the build artifacts from that package.