fix: use toolchain file while building dependencies#281
Open
LtdSauce wants to merge 1 commit intoLukeMathWalker:mainfrom
Open
fix: use toolchain file while building dependencies#281LtdSauce wants to merge 1 commit intoLukeMathWalker:mainfrom
LtdSauce wants to merge 1 commit intoLukeMathWalker:mainfrom
Conversation
This commit make the cargo build command that builds the dependencies actually adhere to the toolchain file if it was present in the recipe. Before this it was ignored and thus the next call to cargo build would rebuild all dependencies again, but then with what is actually contained in the toolchain file. This was because the environment variable 'RUSTUP_TOOLCHAIN' was already set and so the toolchain file was not considered, see here for details: https://rust-lang.github.io/rustup/overrides.html
Author
|
Hi! I have not found tests, that actually check the cargo invokation and thus did not add any tests for this. This could be reproduced using any recipe that contains a toolchain, that uses a different channel/version than what is installed by default. I used the following for example: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit make the cargo build command that builds the dependencies actually adhere to the toolchain file if it was present in the recipe.
Before this it was ignored and thus the next call to cargo build would rebuild all dependencies again, but then with what is actually contained in the toolchain file. This was because the environment variable 'RUSTUP_TOOLCHAIN' was already set and so the toolchain file was not considered, see here for details:
https://rust-lang.github.io/rustup/overrides.html
This should fix #271 (and also solve the missing piece for #231)