Circumvented Deprecated API Call / Invalid Arg Error #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks for which API is present. Added error catch to return default values if mountID is nil or invalid.
Bitwise1057
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced UnitBuff with C_TooltipInfo.GetUnitBuff, since UnitBuff has been deprecated.
Resolved error:
Message: ...nterface/AddOns/CameraOverShoulderFix/correction.lua:297: attempt to call upvalue 'UnitBuff' (a nil value)Patched an issue with the mount journal API that repeatedly threw:
Message: bad argument #1 to '?' (Usage: local name, spellID, icon, isActive, isUsable, sourceType, isFavorite, isFactionSpecific, faction, shouldHideOnChar, isCollected, mountID, isSteadyFlight = C_MountJourn...)This error prevented the camera from resetting correctly after dismounting.
Added API checks and error handling as a temporary workaround until a proper fix is in place.
These changes should stop the addon from throwing runtime errors in current builds while maintaining functionality.