[pull] forks/amsterdam from ethereum:forks/amsterdam #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(tests): refactor to less error prone logic for eip7934 tests * refactor(tests): performance gain linear search -> binary search * feat(tests): perf gain, find a tx that is within +/- 15 bytes not 1 byte - extradata field is 32 bytes so we can adjust using the block's extradata up to +/- 15 bytes or so (we will need to add one more for rlp at limit + 1 byte invalid tests). This makes it so we should selfomly even hit the binary search logic. * refactor(tests): Get rid of dead binary search code; new tolerance does the job * fix(tests): fix typo - use consolidation requests * refactor(tests): cleanup from comments on PR #2078
* feat(test-cli): add hasher compare subcommand * test(test-cli): add unit tests for hasher * refactor(test-cli): remove dead code and redundant comments - Remove unused HashableItem.print() method. - Remove obvious inline comments that duplicate code intent. - Simplify multi-line type annotation for differences list. * refactor(test-cli): simplify compare by diffing trees directly - Replace parse_hash_lines() with collect_hashes() that walks item tree. - Simplify display_diff() to work with dicts instead of parsing strings. - Eliminate round-trip: format → parse → diff is now just collect → diff.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )