Improve generic pattern to support "T.*-"#3015
Merged
sumneko merged 4 commits intoLuaLS:masterfrom Jan 2, 2025
Merged
Conversation
…Pattern to support "`T`.*-", prevent crash with "`T``T`" and when tokens >= 8, fix wrong getStart of result.
…-" without name token before code. Added tests.
T.*-"T\.*-"
T\.*-"T.*-"
Contributor
Author
|
Ohh, I need to figure out how to run the tests 🫠 upd. Yeah I just copied bin from extension then launched test.lua |
Collaborator
|
nice work, thank you! |
TIMONz1535
added a commit
to TIMONz1535/lua-language-server
that referenced
this pull request
Jan 6, 2025
…y and comment without a space. Fixed regression.
TIMONz1535
added a commit
to TIMONz1535/lua-language-server
that referenced
this pull request
Jan 6, 2025
…y and comment without a space. Fixed regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3014
Technical changes:
.and*as Symbol because I want to parse these tokens after code block, otherwise they just disappeared:.*-and integer as part of the name but only after code block.for i = 2, 8 doand finishOffset remainednil.content ~= nextContentwhen暂时不支持多genericthen we call("%s%s"):format(val)and 2nd argument was expected.starttokens of returned result.