Send the correct insertTextFormat#3005
Merged
sumneko merged 1 commit intoLuaLS:masterfrom Dec 26, 2024
Merged
Conversation
Per LSP specification, `insertTextFormat` should be `2` for snippets and `1` for plain text. Using `2` unconditionally can make clients behave in unexpected ways. The code calling into `provider.lua` sets `insertTextFormat` to 2 for all snippets and leaves it nil for other types, so we can reuse that information in `provider.lua` to make sure we send the correct value.
Collaborator
|
Thank you! |
andrewbraxton
added a commit
to andrewbraxton/lua-language-server
that referenced
this pull request
Jan 3, 2025
The PR LuaLS#3005 assumed that all snippets were setting `insertTextFormat` to 2 and leaving plaintext completions nil, but that was not the case. Function completions need to be marked as snippets too. fixes LuaLS#3021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per LSP specification,
insertTextFormatshould be2for snippets and1for plain text. Using2unconditionally can make clients behave in unexpected ways. For example, thenvim-cmpplugin for Neovim doesn't properly handle the case of completion inside of a snippet wheninsertTextFormatis incorrect.The code calling into
provider.luasetsinsertTextFormatto 2 for all snippets and leaves it nil for other types, so we can reuse that information inprovider.luato make sure we send the correct value.This was previously brought up in #992, but the closing PR didn't resolve the issue directly.