fix: incorrect infer of function array annotation on tables#2991
Merged
sumneko merged 1 commit intoLuaLS:masterfrom Dec 16, 2024
Merged
fix: incorrect infer of function array annotation on tables#2991sumneko merged 1 commit intoLuaLS:masterfrom
sumneko merged 1 commit intoLuaLS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2367
bugfix explanation:
{ function() end }is parsed astableexpbut it is not considered as assign type
=> so it is not receiving type infer from
---@type {[integer]: fun()}annotationWay to
@typeannotate array of functions without { [integer]: fun() } #2367 (comment)---@type fun()[]annotation is giving outdoc.type.functionwhen inferringtableindexoperationbut is ignored by the current logic
=> so
{ [1] = function () end }cannot receive type inferWay to
@typeannotate array of functions without { [integer]: fun() } #2367 (comment)