Rename Project -> Session across code, resources, and locales#591
Merged
Conversation
Aligns code and resource names with the canonical terminology: .lxj =
Session (persisted workspace) and .lxp = Session File (per-file state).
The code and resource keys still used the legacy "Project" wording.
Renamed:
- Types: ProjectFileHandler/IProjectFileHandler -> SessionHandler/
ISessionHandler, ProjectData -> SessionData, ProjectPersister ->
SessionPersister, ProjectLoadOutcome/Result/ValidationResult/
DlgResult -> Session*, ProjectFileResolver/Validator -> SessionFile*,
ProjectLoadDlg -> SessionLoadDlg
- Methods: LoadProject/SaveProject -> LoadSession/SaveSession,
LoadProjectData -> LoadSessionData, ResolveProjectFiles ->
ResolveSessionFiles, ValidateProject -> ValidateSession,
OnLoadProjectToolStripMenuItemClick -> OnLoadSessionTool...
- Properties/fields: ProjectFilePath -> SessionFilePath,
_projectFileHandler -> _sessionHandler, _projectFileCallback ->
_loadSessionCallback
- Resource keys: LoadProject_UI_* -> LoadSession_UI_*,
LogTabWindow_UI_Project_Session_Default_Filter ->
LogTabWindow_UI_Session_Default_Filter, loadProjectToolStripMenuItem
-> loadSessionToolStripMenuItem
- Resource values updated in en/de/zh-CN: "Project Load Failed" /
"Error loading project file" replaced; merged with existing
SessionLoadFailed key (was a near-duplicate)
Backward compatibility:
- Existing .lxj files on disk continue to load: SessionData has
[JsonProperty("ProjectFilePath")] pinning the JSON key, and the
field is also re-set from the file path on load so even files
without this key resolve correctly.
- Behavior unchanged - no runtime semantics affected.
The edge case A fix in FileOperationService.AddMultiFileTab came in via the Development merge after PR2's sed pass had already run, so it kept the old field name. Renamed to match _loadSessionCallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns code and resource names with the canonical terminology: .lxj = Session (persisted workspace) and .lxp = Session File (per-file state). The code and resource keys still used the legacy "Project" wording.
Renamed:
Backward compatibility: