Skip to content

feat(macos): implement Unicode text input #4980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boomyao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(macos): implement Unicode text input #4980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion src/platform/macos/input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <chrono>
#include <iostream>
#include <thread>
#include <vector>

// platform includes
#include <ApplicationServices/ApplicationServices.h>
Expand Down Expand Up @@ -295,7 +296,42 @@
}

void unicode(input_t &input, char *utf8, int size) {
BOOST_LOG(info) << "unicode: Unicode input not yet implemented for MacOS."sv;
auto macos_input = static_cast<macos_input_t *>(input.get());

// Convert UTF-8 to UTF-16 via CFString
CFStringRef cfStr = CFStringCreateWithBytes(kCFAllocatorDefault,

Check failure on line 302 in src/platform/macos/input.cpp

View workflow job for this annotation

GitHub Actions / Common Lint / Common Lint 

code should be clang-formatted
(const UInt8 *) utf8, size, kCFStringEncodingUTF8, false);
if (!cfStr) {
BOOST_LOG(warning) << "unicode: Failed to convert UTF-8 input"sv;
return;
}

CFIndex length = CFStringGetLength(cfStr);
std::vector<UniChar> utf16(length);
CFStringGetCharacters(cfStr, CFRangeMake(0, length), utf16.data());
CFRelease(cfStr);

// Inject each character (or surrogate pair) as a key down/up event
for (CFIndex i = 0; i < length;) {
UniCharCount charLen = 1;
if (i + 1 < length &&
CFStringIsSurrogateHighCharacter(utf16[i]) &&
CFStringIsSurrogateLowCharacter(utf16[i + 1])) {
charLen = 2;
}

CGEventRef keyDown = CGEventCreateKeyboardEvent(macos_input->source, 0, true);
CGEventKeyboardSetUnicodeString(keyDown, charLen, &utf16[i]);
CGEventPost(kCGHIDEventTap, keyDown);
CFRelease(keyDown);

CGEventRef keyUp = CGEventCreateKeyboardEvent(macos_input->source, 0, false);
CGEventKeyboardSetUnicodeString(keyUp, charLen, &utf16[i]);
CGEventPost(kCGHIDEventTap, keyUp);
CFRelease(keyUp);

i += charLen;
}
}

int alloc_gamepad(input_t &input, const gamepad_id_t &id, const gamepad_arrival_t &metadata, feedback_queue_t feedback_queue) {
Expand Down
Loading