fix(linux): use FQDN service name in desktop launcher#4874
Open
htrex wants to merge 1 commit intoLizardByte:masterfrom
Open
fix(linux): use FQDN service name in desktop launcher#4874htrex wants to merge 1 commit intoLizardByte:masterfrom
htrex wants to merge 1 commit intoLizardByte:masterfrom
Conversation
The .desktop file runs `systemctl start --u sunshine`, which relies on the `sunshine.service` alias. This alias only exists after the user runs `systemctl --user enable`, but the desktop launcher is intended to work without prior enable. Since commit daa99db renamed the service to `app-@PROJECT_FQDN@`, the desktop launcher should use the full service name directly so it works regardless of whether the service has been enabled.
|
Member
|
Thank you for the PR submission, but I noticed you didn't use our PR template. Please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
.desktoplauncher runs:This relies on the
sunshine.servicealias, which is only created when the user runssystemctl --user enable app-dev.lizardbyte.app.Sunshine. Without a priorenable, the alias doesn't exist and clicking the launcher silently fails — Sunshine doesn't start and there's no error feedback.This became an issue after daa99db renamed the service to FQDN (
app-dev.lizardbyte.app.Sunshine), but the.desktopfile was not updated to match.Fix
Use the full FQDN service name via cmake variable:
This resolves to
app-dev.lizardbyte.app.Sunshine, which is the actual unit name and works regardless of whether the service has been enabled.