Skip to content

fix(network): pairing timeout#197

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/network/pairing-timeout
May 25, 2026
Merged

fix(network): pairing timeout#197
ReenigneArcher merged 1 commit into
masterfrom
fix/network/pairing-timeout

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

Description

Increase pairing timeout to 90s, while keeping all other timeouts at 5s.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.02%. Comparing base (c024b2d) to head (7f19bdf).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/network/host_pairing.cpp 15.38% 8 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   63.05%   63.02%   -0.03%     
==========================================
  Files          32       32              
  Lines        5235     5239       +4     
  Branches     2385     2386       +1     
==========================================
+ Hits         3301     3302       +1     
- Misses        931     1112     +181     
+ Partials     1003      825     -178     
Flag Coverage Δ
Linux 63.35% <8.33%> (-0.03%) ⬇️
macOS 49.95% <15.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/network/host_pairing.h 0.00% <ø> (ø)
src/network/host_pairing.cpp 45.40% <15.38%> (-0.06%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c024b2d...7f19bdf. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher ReenigneArcher merged commit a37b78e into master May 25, 2026
15 of 16 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/network/pairing-timeout branch May 25, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant