Skip to content

Fix TranslatedMessage leaking whitespace #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KentoNishi merged 1 commit into from
May 13, 2026
+15 −17
Merged

Fix TranslatedMessage leaking whitespace #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions src/components/TranslatedMessage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
});
}

$: showTL = Boolean(translatedMessage && !showOriginal && translatedMessage.trim() !== text.trim());
$: hasTranslation = Boolean(translatedMessage && translatedMessage.trim() !== text.trim());
$: showTL = hasTranslation && !showOriginal;

$: if ($translateTargetLanguage !== translatedLanguage) {
translatedMessage = '';
Expand All @@ -30,34 +31,31 @@
$: translatedColor = forceTLColor === Theme.DARK
? 'text-translated-dark'
: `text-translated-light ${forceTLColor === Theme.YOUTUBE ? 'dark:text-translated-dark' : ''}`;

</script>

<!-- Comments absorb indentation whitespace that would leak between adjacent text runs.
The translate icon's visual gap is provided by margin on .material-icons in the style block. -->
<span
class={showTL ? translatedColor : ''}
class:cursor-pointer={translatedMessage}
class:entrance-animation={translatedMessage}
class:cursor-pointer={hasTranslation}
class:entrance-animation={hasTranslation}
on:click={() => {
if (translatedMessage) {
if (hasTranslation) {
showOriginal = !showOriginal;
$refreshScroll = true;
}
}}
>
<span>
{showTL ? translatedMessage : text}
</span>

{#if translatedMessage}
<span class="shifted-icon">
<Icon xs={true} block={false}>
translate
</Icon>
</span>
{/if}
</span>
><!--
-->{showTL ? translatedMessage : text}<!--
-->{#if hasTranslation}<!--
--><span class="shifted-icon"><Icon xs={true} block={false}>translate</Icon></span><!--
-->{/if}<!--
--></span>

<style>
.shifted-icon :global(.material-icons) {
transform: translateY(1px);
margin: 0 0.25em;
}
</style>
Loading