Run parser: deserialize the AutoSplitterSettings #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKnauth
changed the title
AlexKnauth
force-pushed
the
Refragg-2
branch
2 times, most recently
from
43cfe17 to
ba19f96
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
2 times, most recently
from
893d213 to
62c9bf9
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
2 times, most recently
from
1811791 to
f0feb78
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
3 times, most recently
from
ffca5d4 to
8135b53
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
3 times, most recently
from
194f276 to
5da2a24
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
3 times, most recently
from
1ea8eb9 to
82f2caa
Compare
AlexKnauth
force-pushed
the
Refragg-2
branch
from
82f2caa to
f691684
Compare
This commit implements the deserialization of the AutoSplitterSettings XML section of a LiveSplit splits file. This can surely use some improvements regarding the compatibility without the auto-splitting feature and some other things. I think it is good as a first step though and we can keep iterating on it.
AlexKnauth
force-pushed
the
Refragg-2
branch
from
f691684 to
652d2b4
Compare
Contributor
Author
|
With how I'm looking at this again now after seeing how an ASR autospliter's settings work slightly differently once it's actually in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @Refragg, I updated it to use the new settings map and settings value types.