Migrate Jenkins build to k8s-test-2204-8 agent#43
Open
vemulaanvesh wants to merge 3 commits intomasterfrom
Open
Migrate Jenkins build to k8s-test-2204-8 agent#43vemulaanvesh wants to merge 3 commits intomasterfrom
vemulaanvesh wants to merge 3 commits intomasterfrom
Conversation
Switches mvnBuildPipeline from the GCE Ubuntu 22.04 agent (jenkins-agent-hub-ubuntu-2204-n1-standard-8) to the new ephemeral k8s pod agent (k8s-test-2204-8). The k8s pod image ships Java 8/11/17/21, so the explicit JAVA_HOME = java-8 above continues to work. Note: this Jenkinsfile is still on liveramp-base@v2; the other libs (aggregation_lib, refresher_waiter) use @v3.0. Library bump is out of scope here -- the agentLabel field is honoured by both versions. Co-authored-by: Cursor <cursoragent@cursor.com>
WalkthroughJenkins pipeline reference updated to a k8s-focused shared library and swaps ChangesJenkins pipeline k8s migration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 8/10 reviews remaining, refill in 12 minutes. Comment |
Switch from the shared k8s-test-2204-8 pool to the dedicated k8s-migration-test-2204 cloud (defined in LiveRamp/kubernetes-deployments PR #6355) so the GCE->K8s migration validation runs on an isolated EXCLUSIVE pool. Avoids interleaving with unrelated org builds that default to k8s-common, which makes failures attributable and prevents the test pool from being pinned by long-running unrelated jobs.
…line step The K8s pod agent image (jenkins-agent-2204-k8s:45) does not include ssh-client, so the GCE-flavor mvnBuildPipeline / mvnDockerBuildAndPublishPipeline steps from liveramp-base@v3.0/v2 fail at SCM checkout with 'ssh: not found'. Switch to the K8s-prepped variants from jenkins_pipelines PR #316: liveramp-base@DEV-6236/k8s-shared-library mvnBuildPipelineK8s / mvnDockerBuildAndPublishPipelineK8s Required companion change: remove the SSHCheckoutTrait from the multibranch SCM source so SCM checkout uses HTTPS via the existing github-app-org-token credential.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Jenkinsfile`:
- Around line 6-7: The pipeline uses agentLabel set to 'k8s-migration-test-2204'
which mismatches the PR/test plan; update the agentLabel value used in the
mvnBuildPipelineK8s block to 'k8s-test-2204-8' (the label specified by the PR)
so the Jenkins controller can schedule the job on the correct Kubernetes pods;
locate the agentLabel assignment inside the mvnBuildPipelineK8s block and
replace the string accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+6
to
+7
| mvnBuildPipelineK8s { | ||
| agentLabel = 'k8s-migration-test-2204' |
There was a problem hiding this comment.
Agent label mismatch can block CI scheduling
Line 7 uses k8s-migration-test-2204, but the PR objective/test plan specifies k8s-test-2204-8. If that label is not present on the Jenkins controller, builds will queue/fail instead of running on the new K8s pods.
Suggested fix
mvnBuildPipelineK8s {
- agentLabel = 'k8s-migration-test-2204'
+ agentLabel = 'k8s-test-2204-8'
}As per coding guidelines, "Comment only when the issue must be resolved before merge — otherwise remain silent."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| mvnBuildPipelineK8s { | |
| agentLabel = 'k8s-migration-test-2204' | |
| mvnBuildPipelineK8s { | |
| agentLabel = 'k8s-test-2204-8' | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Jenkinsfile` around lines 6 - 7, The pipeline uses agentLabel set to
'k8s-migration-test-2204' which mismatches the PR/test plan; update the
agentLabel value used in the mvnBuildPipelineK8s block to 'k8s-test-2204-8' (the
label specified by the PR) so the Jenkins controller can schedule the job on the
correct Kubernetes pods; locate the agentLabel assignment inside the
mvnBuildPipelineK8s block and replace the string accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
mvnBuildPipelinefrom the GCE Ubuntu 22.04 agent (jenkins-agent-hub-ubuntu-2204-n1-standard-8) to the new ephemeral Kubernetes pod agent labelk8s-test-2204-8.The new agent (cloud
K8S-STD-2204-8, imagejenkins-agent-2204-k8s:stable) was added to the prod Hub Services Jenkins controller in kubernetes-deployments#6337. See K8S-AGENTS-GUIDE.md for the full label list.Why
Notes
env.JAVA_HOME = java-8-openjdk-amd64is preserved; the 2204 image ships Java 8/11/17/21.liveramp-base@v2(the other migrated libs use@v3.0). A library bump is intentionally out of scope here so this PR is one isolated change. TheagentLabelfield is honoured by both@v2and@v3.0.Test plan
k8s-test-2204-8pod (look forRunning on k8s-test-2204-8-...in the build log instead ofgce-2204-ubuntu-gen-8-...)mvn clean deploycompletes; deploy to Artifactory succeedsMade with Cursor
Summary by CodeRabbit