DEV-6236: Test K8s pod agent (k8s-test-2204-8)#42
Open
vemulaanvesh wants to merge 3 commits intomasterfrom
Open
DEV-6236: Test K8s pod agent (k8s-test-2204-8)#42vemulaanvesh wants to merge 3 commits intomasterfrom
vemulaanvesh wants to merge 3 commits intomasterfrom
Conversation
WalkthroughJenkinsfile: the Maven pipeline's ChangesJenkins agent label update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 6/10 reviews remaining, refill in 22 minutes and 16 seconds. Comment |
vemulaanvesh
added
the
change/standard
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Jenkinsfile`:
- Around line 2-7: Replace the test-scoped library and agent references with
their production equivalents: change the `@Library` invocation that currently uses
"liveramp-base@DEV-6236/k8s-shared-library" to the canonical production tag
(e.g., "liveramp-base@master" or the appropriate release tag) and update the
mvnBuildPipelineK8s block's agentLabel (currently 'k8s-test-2204-8') to the
standard CI agent label (e.g., 'k8s-build' or your org's production agent);
ensure the changes are made where the `@Library`(...) declaration and the
agentLabel = 'k8s-test-2204-8' appear so the pipeline references supported,
non-test resources before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Comment on lines
+2
to
+7
| @Library("liveramp-base@DEV-6236/k8s-shared-library") _ | ||
|
|
||
| env.JAVA_HOME = '/usr/lib/jvm/java-8-openjdk-amd64' | ||
|
|
||
| mvnBuildPipeline { | ||
| agentLabel = 'jenkins-agent-hub-ubuntu-2204-n1-standard-8' | ||
| mvnBuildPipelineK8s { | ||
| agentLabel = 'k8s-test-2204-8' |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
jf="$(fd -a '^Jenkinsfile$' | head -n1)"
echo "Checking: $jf"
nl -ba "$jf" | sed -n '1,20p'
if rg -n 'DEV-6236/k8s-shared-library|k8s-test-2204-8' "$jf"; then
echo "BLOCKER: Jenkinsfile still contains test-only refs. Revert to stable refs before merge."
exit 1
fi
echo "OK: no test-only refs found."Repository: LiveRamp/daemon_lib
Length of output: 165
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find and read the Jenkinsfile
jf="$(fd -a '^Jenkinsfile$' | head -n1)"
echo "=== Jenkinsfile Location: $jf ==="
echo ""
# Display first 20 lines with line numbers using sed
echo "=== First 20 lines of Jenkinsfile ==="
sed -n '1,20p' "$jf" | cat -n
echo ""
echo "=== Checking for test-only references ==="
# Check for the specific test references mentioned in review
if grep -n 'DEV-6236/k8s-shared-library' "$jf"; then
echo "✓ Found test library reference"
else
echo "✗ Test library reference NOT found"
fi
if grep -n 'k8s-test-2204-8' "$jf"; then
echo "✓ Found test agent label"
else
echo "✗ Test agent label NOT found"
fiRepository: LiveRamp/daemon_lib
Length of output: 591
Test-only library and agent references must be reverted before merging to master.
Lines 2 and 7 reference test-scoped resources (DEV-6236/k8s-shared-library and k8s-test-2204-8). If merged to master, the CI pipeline will break once the DEV branch is removed and the test agent is decommissioned after validation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Jenkinsfile` around lines 2 - 7, Replace the test-scoped library and agent
references with their production equivalents: change the `@Library` invocation
that currently uses "liveramp-base@DEV-6236/k8s-shared-library" to the canonical
production tag (e.g., "liveramp-base@master" or the appropriate release tag) and
update the mvnBuildPipelineK8s block's agentLabel (currently 'k8s-test-2204-8')
to the standard CI agent label (e.g., 'k8s-build' or your org's production
agent); ensure the changes are made where the `@Library`(...) declaration and the
agentLabel = 'k8s-test-2204-8' appear so the pipeline references supported,
non-test resources before merging.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Jenkinsfile (1)
6-8:⚠️ Potential issue | 🟠 MajorRevert the test-only agent label before merging.
k8s-test-2204-8is a validation pod, not a production CI agent. Leaving this inmastermakes the pipeline dependent on a test resource that may be decommissioned after validation.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Jenkinsfile` around lines 6 - 8, The Jenkinsfile currently sets a test-only agent label in the mvnBuildPipeline block (agentLabel = 'k8s-test-2204-8'); revert this by replacing the test validation pod label with the standard CI agent label or removing the override so mvnBuildPipeline uses the default/production agent, ensuring the pipeline doesn't depend on the temporary 'k8s-test-2204-8' resource.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@Jenkinsfile`:
- Around line 6-8: The Jenkinsfile currently sets a test-only agent label in the
mvnBuildPipeline block (agentLabel = 'k8s-test-2204-8'); revert this by
replacing the test validation pod label with the standard CI agent label or
removing the override so mvnBuildPipeline uses the default/production agent,
ensuring the pipeline doesn't depend on the temporary 'k8s-test-2204-8'
resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
https://liveramp.atlassian.net/browse/DEV-6236
Summary
Test PR to validate the new common K8s pod agent (
k8s-test-2204-8) as a drop-in replacement for the GCE Jenkins agentjenkins-agent-hub-ubuntu-2204-n1-standard-8.Changes
DEV-6236/k8s-shared-librarybranch (K8s pipeline steps)mvnBuildPipeline→mvnBuildPipelineK8sagentLabel = 'jenkins-agent-hub-ubuntu-2204-n1-standard-8'→agentLabel = 'k8s-test-2204-8'K8s pod spec (from kubernetes-deployments#6337)
jenkins-agent-2204-k8s:stable(built by linux-provisioning#139) — JDK 8/11/17/21, Docker CLI, gcloud, kubectl, Ruby, Nodedocker:27-dindprivileged — replaces the GCE VM's native Docker daemonTest plan
k8s-test-2204-8label (replacing GCEjenkins-agent-hub-ubuntu-2204-n1-standard-8)DO NOT MERGE — test branch only. Will be closed once K8s agent is validated.
Summary by CodeRabbit