Allow for timeouts in acquiring a daemon lock#31
Draft
pratikmallya wants to merge 2 commits intomasterfrom
Draft
Allow for timeouts in acquiring a daemon lock#31pratikmallya wants to merge 2 commits intomasterfrom
pratikmallya wants to merge 2 commits intomasterfrom
Conversation
The current code waits forever on acquiring a synchronization lock. This can cause issues when there are a large number of daemons. In such a case, the JVM can terminate after waiting for a long time. This can often lead to confusion for users. In this change we: * add a specific exception (LockTimeoutException) to indicate timeouts when acquiring locks and * handle that exception in the config fetching logic. This permits any lock implementation to throw the exception to indicate a timeout when trying to fetch the lock. The exception handler prints a helpful message allowing users to know that the Daemon is stalling on fetching the lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code waits forever on acquiring a synchronization lock.
This can cause issues when there are a large number of daemons. In
such a case, the JVM can terminate after waiting for a long time.
This can often lead to confusion for users.
In this change we:
lock implementation to throw the exception to indicate a timeout
when trying to fetch the lock. The exception handler prints a
helpful message allowing users to know that the Daemon is stalling
on fetching the lock.