Skip to content

feat(TeamParticipants): improve ingame role display for roles without icon#7494

Open
hjpalpha wants to merge 3 commits into
mainfrom
ingame-role-without-icon-improvement-in-teamparticipants
Open

feat(TeamParticipants): improve ingame role display for roles without icon#7494
hjpalpha wants to merge 3 commits into
mainfrom
ingame-role-without-icon-improvement-in-teamparticipants

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented May 12, 2026

Summary

resolves #7491
also adds a missing return anno

before:
image

with this:
image

How did you test this change?

dev

@hjpalpha hjpalpha requested review from a team as code owners May 12, 2026 13:45
@hjpalpha
Copy link
Copy Markdown
Collaborator Author

failed unit tests are unrelated to the PR ...

Comment thread lua/wikis/commons/Widget/Participants/Team/Roster.lua Outdated
@hjpalpha hjpalpha requested a review from mbergen May 12, 2026 14:15
Comment thread lua/wikis/commons/Widget/Participants/Team/Roster.lua Outdated
Co-authored-by: SyntacticSalt <mail@mbergen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roles support in TeamParticipants not optimal

2 participants