feat: use custom html builder for widget3#7467
Open
Rathoz wants to merge 5 commits into
Open
Conversation
hjpalpha
reviewed
May 6, 2026
Rathoz
force-pushed
the
widget3-custom-html
branch
from
637c48e to
0abfab5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Widget3 renderer to build HTML output via a custom string builder instead of relying on mw.html, likely aiming to reduce overhead during render.
Changes:
- Added a custom HTML string builder (
buildHtmlString) including a void/self-closing tag list and attribute escaping. - Updated
Renderer.renderfor HTML-tag VNodes to render children and emit HTML via the new builder (with special handling forfragment).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
ElectricalBoy
left a comment
ElectricalBoy
left a comment
There was a problem hiding this comment.
how does this compare to mw.html lib performance wise?
Collaborator
Author
It's on my TODO To test, you can test if you want. It should perform better in memory management I expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO: Test performance
How did you test this change?