-
Notifications
You must be signed in to change notification settings - Fork 100
feat: add super() implementation #6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1cc70b4 to
9a47b1e
Compare
hjpalpha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the perf implications of this?
negligible: see leagueoflegends:User:ElectricalBoy/Sandbox/PerfTest1 and leagueoflegends:User:ElectricalBoy/Sandbox/PerfTest2 |
|
What's the usecase for this? to call an overridden function of the Base, right? |
function Child:fun()
return self:super():fun()
endI think that this is more readable as it clearly shows with |
Summary
This PR adds
BaseClass.super().How did you test this change?
included tests