feat(TeamParticipant): Wrapper for TeamParticipants #6985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I am not particularly a fan of adding another entrypoint for this |
Collaborator
Author
|
closing in fav of #6986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a wrapper for TeamParticipants.
Intended use is on pages with several TeamParticipants Groups.
Those groups get displayed inside dynamic tabs.
Currently we would have to call each of the Groups by itself and add the dynamic tabs around it manually.
Additionally this can be used as a workaround for the "Compact view" & "Show rosters" Switches not working if there are several TeamParticipants Groups on the same page (see https://liquipedia.net/starcraft2/User:Hjpalpha/wip13 for reproducer)
How did you test this change?
dev
https://liquipedia.net/starcraft2/User:Hjpalpha/wip12