homing: Fix race between joint's homing status and state machine done #3800
+27
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a race condition between a joint's homing status indicator and the state machine running the homing procedure. It was well reproducible using linuxcncrsh sending successive homing commands.
Root cause:
The joint's
homingstatus is deasserted when a joint has been processed. This status update happens in both the EMC_STAT sent via NML and the HAL pins for the joints. It was possible to send a second homing command via NML and fail before the previous homing action was completed, even though the system indicated no homing in progress.The previously homing joint was marked ready with
homedstatus asserted andhomingstatus deasserted. However, the state machine running the homing process was not yet done and had thehoming_activeinternal state still asserted, even tough all joints'homingstatus had been cleared. The processing of the subsequent homing command would fail with an error becausehoming_activewas still asserted.The solution is to delay the deassertion of the joints'
homingstatus indicator until the state machine is done, as indicated byhoming_active. This was fixed for both the NML EMC_STAT and HAL pins.