Gmoccapy: make Tool Table exit more verbose #3792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have no problem with this addition. |
hansu
reviewed
Feb 7, 2026
Comment on lines
+4749
to
+4750
| new_offset_is_zero = all(v == 0.0 for v in new_offset) | ||
| old_offset_is_zero = all(v == 0.0 for v in self.stat.tool_offset) |
Member
There was a problem hiding this comment.
I don't think it's a good idea to compare float with "==" ...
Collaborator
There was a problem hiding this comment.
should be fine in this case, float 0 is exact 0 and if somebody sets offset of 10nm you don't want to treat it as zero.
Member
There was a problem hiding this comment.
Yeah true, that should be fine.
But new_offset != self.stat.tool_offset could give an unwanted message, but maybe that's not very likely....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinuxCNC core behavior:
Activating G43 with zero offsets deactivates tool compensation.
In this situation, G43 behaves like G49.
If the CNC operator is not aware of this, it can have dangerous consequences.
@hansu was not aware of this in the past. See:
#3706 (comment)
I struggled with this as well.
Therefore, I made exiting the Tool Table in Gmoccapy more verbose and added the option to activate G43 when the active offset changes from zero to non-zero.
I would like to ask @Sigma1912 for their opinion on whether this is OK.