Skip to content

Add timeout to MNIST data download #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
massy-o wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Add timeout to MNIST data download #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integration/slices/numpy_mnist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
headers = {
"User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0"
}
request_opts = {"headers": headers, "params": {"raw": "true"}}
request_opts = {"headers": headers, "params": {"raw": "true"}, "timeout": 30}
Copy link
Copy Markdown
Author

@massy-o massy-o May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: The timeout lives in request_opts so the existing requests.get call shape stays the same while the data download no longer waits indefinitely when GitHub stalls.

import os
import requests

Expand Down