Skip to content

Conversation

@sergeytimoshin
Copy link
Contributor

On fresh installs, download-gnark-keys.sh fails with "go: command not found" (exit code 127) because go is installed to .local/go/bin/ but PATH isn't updated until devenv.sh is sourced after installation.
Add GOROOT and PATH exports to shared.sh so locally installed binaries (go, cargo) are available to subsequent installation steps.

On fresh installs, download-gnark-keys.sh fails with "go: command not
  found" (exit code 127) because Go is installed to .local/go/bin/ but
  PATH isn't updated until devenv.sh is sourced after installation.

  Add GOROOT and PATH exports to shared.sh so locally installed binaries
  (Go, Cargo) are available to subsequent installation steps.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • scripts/devenv/shared.sh is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sergey/fix-go-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sergeytimoshin sergeytimoshin merged commit a62d2bb into main Jan 4, 2026
16 checks passed
@sergeytimoshin sergeytimoshin deleted the sergey/fix-go-path branch January 4, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants