Skip to content

Conversation

@ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Dec 15, 2025

Changes:

  • add failing test for ata creation with invalid ata
  • add ctoken close authority check for completeness
    • the close authority can never be initialized in the current implementation added the check to be defensive

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (5)
  • wip
  • draft
  • temp
  • test
  • experimental

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jorrit/chore-add-ctoken-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ananas-block ananas-block changed the title test: create ata fails for invalid ata chore: add test create ata fails for invalid ata, add ctoken close auth check Dec 15, 2025
Copy link
Contributor

@SwenSchaeferjohann SwenSchaeferjohann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ananas-block ananas-block merged commit 7119a91 into main Dec 17, 2025
31 checks passed
@ananas-block ananas-block deleted the jorrit/chore-add-ctoken-test branch December 17, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants