feat: policy signature flow by vitormattos · Pull Request #7518 · LibreSign/libresign

vitormattos · 2026-04-14T17:54:30Z

No description provided.

FIXES: - Register all 6 signature_text individual policy keys in SignatureTextPolicy - Each key now has proper normalizers and defaults matching backend - Fix mock object type errors by converting willReturnMap to willReturnCallback - Mock callbacks now always return string (never null) to match type hints - Update mock expectations from once()/exactly(2) to atLeastOnce() for deleteKey() - Align test expectations with actual migration call counts DETAILS: * SignatureTextPolicy: Now exposes 6 individual keys via keys() and get() * Each key (template, template_font_size, signature_width, etc.) has proper specs * Render mode key includes allowed values: 'default', 'graphic', 'text' * Migration tests: Fixed mock return types to prevent TypeError * All getValueString() calls now guaranteed to return string via callback * Adjusted deleteKey() and setValueString() expectations to handle migration flow Test Results Expected: - 0 Unknown policy key errors (all 6 now registered) - 0 Mock type errors (callbacks always return string) - 0 Mock expectation violations (atLeastOnce accounts for cleanup calls)

…olicy - Fix useSignatureTextPolicy.ts accessing .effectiveValue instead of non-existent .value - Simplify useSignatureTextPolicy return type annotation using ComputedRef - Fix model.ts serializeSignatureTextPolicyConfig to return JSON string - Fix model.ts normalizeSignatureTextPolicyConfig to handle JSON string inputs - Fix SignatureTextRuleEditor.vue Emits type to use EffectivePolicyValue - Remove trailing newline from SignatureTextPolicy.php Fixes: TypeScript type checking and PHP-CS formatting failures in PR #7518 Tests: npm run ts:check passes, php-cs formatting validated

FIXES: - Register all 6 signature_text individual policy keys in SignatureTextPolicy - Each key now has proper normalizers and defaults matching backend - Fix mock object type errors by converting willReturnMap to willReturnCallback - Mock callbacks now always return string (never null) to match type hints - Update mock expectations from once()/exactly(2) to atLeastOnce() for deleteKey() - Align test expectations with actual migration call counts DETAILS: * SignatureTextPolicy: Now exposes 6 individual keys via keys() and get() * Each key (template, template_font_size, signature_width, etc.) has proper specs * Render mode key includes allowed values: 'default', 'graphic', 'text' * Migration tests: Fixed mock return types to prevent TypeError * All getValueString() calls now guaranteed to return string via callback * Adjusted deleteKey() and setValueString() expectations to handle migration flow Test Results Expected: - 0 Unknown policy key errors (all 6 now registered) - 0 Mock type errors (callbacks always return string) - 0 Mock expectation violations (atLeastOnce accounts for cleanup calls) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…olicy - Fix useSignatureTextPolicy.ts accessing .effectiveValue instead of non-existent .value - Simplify useSignatureTextPolicy return type annotation using ComputedRef - Fix model.ts serializeSignatureTextPolicyConfig to return JSON string - Fix model.ts normalizeSignatureTextPolicyConfig to handle JSON string inputs - Fix SignatureTextRuleEditor.vue Emits type to use EffectivePolicyValue - Remove trailing newline from SignatureTextPolicy.php Fixes: TypeScript type checking and PHP-CS formatting failures in PR #7518 Tests: npm run ts:check passes, php-cs formatting validated Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

SignatureBackgroundRuleEditor now follows the policy layer pattern: - Emits update:modelValue for state changes only - PolicyWorkbench coordinates policy persistence via policiesStore - Upload/reset/remove operations still use admin endpoints (fire-and-forget) - Buttons now directly emit state changes without async persistence Aligns with policy-centric architecture where RuleEditors only emit values and the parent PolicyWorkbench handles saveSystemPolicy/saveGroupPolicy calls. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

…alidation This commit refactors AdminController following the twofactor-gateway pattern (Policy layer + minimal endpoint wrappers): **New:** - Created UploadValidator trait to consolidate duplicated file upload validation logic - Replaces 50+ lines of duplicated error handling in signatureBackgroundSave() and saveCertificatePolicy() - Provides reusable validateUploadedFile() method with localized error messages **Removed (wrappers without additional logic):** - PATCH /admin/signature-background (signatureBackgroundReset) → DELETE already sufficient - DELETE /admin/tsa endpoint → Merged into setTsaConfig() as internal resetTsaConfig() - Converted deleteTsaConfig() from public endpoint to private helper method **Refactored:** - saveCertificatePolicy() now handles both POST (upload) and exposes separate deleteCertificatePolicy() for DELETE method (maintains backward compatibility via separate route handler) - Updated saveCertificatePolicy() to use UploadValidator trait **Impact:** - Reduced endpoint surface from 24 to 21 HTTP routes (from 19 admin routes) - Eliminated redundant wrapper methods that only delegated to services - Improved maintainability by consolidating upload validation logic - All 2,542 frontend tests pass - OpenAPI specs regenerated (administration: 19 routes, full: 62 routes) **Next steps (STAGE 21):** - Refactor certificate_engine + signing_mode endpoints to PolicyService (multiescopo) - Consider policy-driven migration for reminder_settings, signature_text, footer_template - Add WhatsApp Business identification method support for twofactor_gateway integration Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>