Skip to content

Fix LoadAdditionalListener and bad nodes (Vue 3 migration)#7318

Open
ciaens wants to merge 1 commit intoLibreSign:mainfrom
ciaens:fix/three-dots-menu
Open

Fix LoadAdditionalListener and bad nodes (Vue 3 migration)#7318
ciaens wants to merge 1 commit intoLibreSign:mainfrom
ciaens:fix/three-dots-menu

Conversation

@ciaens
Copy link

@ciaens ciaens commented Mar 18, 2026

Resolves: #7235

EDIT: only tested on stable32

📝 Summary

LoadAdditionalListener loads libresign-init (which registers the file actions) but never provides the certificate_ok initial state. The enabled() check always returned false.

During the Vue 3 migration, all file action callbacks were changed to use object destructuring ({ nodes }) but @nextcloud/files passes flat arguments (nodes, view) / (node, view, dir). So nodes was always undefined.

🧪 How to test

  1. Access your files
  2. Click on a three-dot menu (on a pdf for example)
  3. see that the shortcut is there (at the top)

Also, there is the libresign icon applied for signed documents.

✅ Checklist

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI -> used it to bisect the changes in releases (between 12.2.X / 12.3.X)

@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Mar 18, 2026
@welcome
Copy link

welcome bot commented Mar 18, 2026

Thanks for opening your first pull request in this repository! ✌️

@ciaens ciaens force-pushed the fix/three-dots-menu branch from ff425f3 to caf08df Compare March 18, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 0. Needs triage

Development

Successfully merging this pull request may close these issues.

Missing LibreSign entry in three-dots Nextcloud menu

1 participant