Fix LoadAdditionalListener and bad nodes (Vue 3 migration)#7318
Open
ciaens wants to merge 1 commit intoLibreSign:mainfrom
Open
Fix LoadAdditionalListener and bad nodes (Vue 3 migration)#7318ciaens wants to merge 1 commit intoLibreSign:mainfrom
ciaens wants to merge 1 commit intoLibreSign:mainfrom
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
ff425f3 to
caf08df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #7235
EDIT: only tested on stable32
📝 Summary
LoadAdditionalListener loads libresign-init (which registers the file actions) but never provides the certificate_ok initial state. The enabled() check always returned false.
During the Vue 3 migration, all file action callbacks were changed to use object destructuring ({ nodes }) but @nextcloud/files passes flat arguments (nodes, view) / (node, view, dir). So nodes was always undefined.
🧪 How to test
Also, there is the libresign icon applied for signed documents.
✅ Checklist
🤖 AI (if applicable)