Skip to content

Update field names in serializeVisibleElements to use producer & consumer names#7317

Open
ciaens wants to merge 1 commit intoLibreSign:mainfrom
ciaens:fix/visible-elements-coordinates
Open

Update field names in serializeVisibleElements to use producer & consumer names#7317
ciaens wants to merge 1 commit intoLibreSign:mainfrom
ciaens:fix/visible-elements-coordinates

Conversation

@ciaens
Copy link

@ciaens ciaens commented Mar 18, 2026

Resolves: #7316

EDIT: only tested on stable32

📝 Summary

In src/store/files.js:868-875, the serializeVisibleElements() function was mapping coordinate fields to the wrong names: x, y, w, h instead of the correct page, top, left, width, height.

The buildVisibleElements() function in VisibleElements.vue creates coordinates with { page, width, height, left, top }, matching what the backend's FileElementService::translateCoordinatesToInternalNotation() expects. But serializeVisibleElements() was looking for x/y/w/h properties that don't exist, so the API received undefined values for all coordinates. This caused the signature position to silently fail to save & no error because the request structure was valid, but the coordinates were empty.

🧪 How to test

  • select a file
  • add an account for signing
  • place a signature somewhere
  • check that the signature location just placed is correctly saved by re-opening the doc

✅ Checklist

@github-project-automation github-project-automation bot moved this to 0. Needs triage in Roadmap Mar 18, 2026
@ciaens ciaens changed the title Update field names in serializeVisibleElements to patch producer & consumer names Update field names in serializeVisibleElements to use producer & consumer names Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 0. Needs triage

Development

Successfully merging this pull request may close these issues.

Signature locations are not saved, preventing users to sign anything

1 participant