Skip to content

DomElement: Throw std::runtime_error if data is not XML #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ubruhin merged 1 commit into from
Apr 29, 2026
Merged

DomElement: Throw std::runtime_error if data is not XML #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions parseagle/common/domelement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ DomElement DomElement::parse(const QByteArray& data)

DomElement DomElement::parseDocument(QByteArray data)
{
// Sanity check that no Eagle v5 (binary) project is imported. To avoid
// false-positives, we test for several patterns.
if ((!data.contains("<?xml")) &&
(!data.contains("<!DOCTYPE eagle")) &&
(!data.contains("<eagle version"))) {
throw std::runtime_error("File does not seem to be from EAGLE v6 or "
"later (no XML node found). Note that files "
"from EAGLE v5 or older are not supported.");
}

// Workaround for garbage in some Eagle XML files, see
// https://gitlab.com/kicad/code/kicad/-/work_items/11008
data.replace("\x0c", "");
Expand Down
Loading