fix(docker): secure environment files in Docker setup#8
Open
pedrojreis wants to merge 1 commit intoLibreChat-AI:mainfrom
Open
fix(docker): secure environment files in Docker setup#8pedrojreis wants to merge 1 commit intoLibreChat-AI:mainfrom
pedrojreis wants to merge 1 commit intoLibreChat-AI:mainfrom
Conversation
* Prevent copying of `.env` and `env.sh` into the public `www/` directory. * Ensure sensitive files are stored outside the document root to avoid exposure. * Update comments for clarity on the handling of environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
.envandenv.shinto the publicwww/directory.What is the current behavior?
When one does leverage this sandbox to use Artifacts in Librechat is also exposing the .env file.
I know that the API_KEY in it it's not that critical, but for an attacker is enough to know what's installed and how to get in.
As enterprises goes, this is a critical issue.
What is the new behavior?
It wont copy the .env into www/ directory
Checklist